Skip to content

Hacktoberfest 2020 - coding style for project_euler problem 56 #3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Hacktoberfest 2020 - coding style for project_euler problem 56 #3084

wants to merge 3 commits into from

Conversation

fa1l
Copy link
Contributor

@fa1l fa1l commented Oct 9, 2020 •
edited
Loading

Describe your change:

Related to #2786

  • Added solution function.

  • Improved documentation.

  • Using generators instead unnecessary list comprehension.

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@fa1l fa1l changed the title Pe 56 Hacktoberfest 2020 - coding style for project_euler problem 56 Oct 9, 2020
@fa1l fa1l closed this Oct 9, 2020
@fa1l
Copy link
Contributor Author

fa1l commented Oct 9, 2020

Didn't see it's already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fa1l